NiniJiaying / pe

0 stars 0 forks source link

[markT command] error message not accurate #3

Open NiniJiaying opened 3 years ago

NiniJiaying commented 3 years ago

Issue description

markT command's error message is not accurate.

Steps to reproduce the issue

  1. type "markT 4 i/"

What's the expected result?

What's the actual result?

nus-pe-bot commented 3 years ago

Team's Response

Thank you for your feedback. The behaviour shown is the expected behaviour.

When the “markT 4 i/“ command is entered. The input for the todo index is indeed invalid. This goes for whether the index provided is empty, or an invalid character such as "a" is provided or, an invalid todo index that doesn't exist such as "9999999" is provided.

Furthermore, with such an error message, the user is alerted that there is a problem with the input provided for the todo index. Hence for all such situations, the user is aware of where to look for and identify his error, in this case being "i/", an empty input provided. As such it is clear and obvious to the user that the empty input he provided is wrong, and he simply needs to correct the error with a valid todo index. As such, the severity of this bug report has also been marked as "very low".

In addition, it is clearly stated in the user guide that todo index must be a positive integer, as shown in this screenshot: Screenshot 2021-04-19 at 03.38.25.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I am not arguing about the definition of Index. Just trying to suggest that the error message could be more accurate. In the case where no index is provided, the most suitable error message should be something like "Index is compulsory. Please provide an index." instead of telling the user that the index provided is invalid while there is no index provided.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]