NiniJiaying / pe

0 stars 0 forks source link

[deleteT command] error message is inaccurate #4

Open NiniJiaying opened 3 years ago

NiniJiaying commented 3 years ago

Issue description

deleteT command’s error message is not accurate.

Steps to reproduce the issue

  1. type “deleteT 4 i/“

What’s the expected result?

What’s the actual result?

nus-pe-bot commented 3 years ago

Team's Response

This issue is marked as a duplicate to issue #701, as it references the same type of behaviour and error response.

Thank you for your feedback. The behaviour shown is the expected behaviour.

When the “ deleteT 4 i/“ command is entered. The input for the todo index is indeed invalid. This goes for whether the index provided is empty, or an invalid character such as "a" is provided or, an invalid todo index that doesn't exist such as "9999999" is provided.

Furthermore, with such an error message, the user is alerted that there is a problem with the input provided for the todo index. Hence for all such situations, the user is aware of where to look for and identify his error, in this case being "i/", an empty input provided. As such it is clear and obvious to the user that the empty input he provided is wrong, and he simply needs to correct the error with a valid todo index. As such, the severity of this bug report has also been marked as "very low".

In addition, it is clearly stated in the user guide that todo index must be a positive integer, as shown in this screenshot: Screenshot 2021-04-19 at 03.38.25.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[markT command] error message not accurate

Issue description

markT command's error message is not accurate.

Steps to reproduce the issue

  1. type "markT 4 i/"

What's the expected result?

  • A error message telling that the index should not be empty.

What's the actual result?

  • “The todo index provided is invalid.” while no index was actually provided.

[original: nus-cs2103-AY2021S2/pe-interim#701] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your feedback. The behaviour shown is the expected behaviour.

When the “markT 4 i/“ command is entered. The input for the todo index is indeed invalid. This goes for whether the index provided is empty, or an invalid character such as "a" is provided or, an invalid todo index that doesn't exist such as "9999999" is provided.

Furthermore, with such an error message, the user is alerted that there is a problem with the input provided for the todo index. Hence for all such situations, the user is aware of where to look for and identify his error, in this case being "i/", an empty input provided. As such it is clear and obvious to the user that the empty input he provided is wrong, and he simply needs to correct the error with a valid todo index. As such, the severity of this bug report has also been marked as "very low".

In addition, it is clearly stated in the user guide that todo index must be a positive integer, as shown in this screenshot: Screenshot 2021-04-19 at 03.38.25.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]