Use object to generate insert instead of values

[PierreLeresteux]

I create a new method in the Insert builder to generate row using an object instead of giving a Map of list of values. I do this, because, I use a lot DbSetup, and sometimes I like to create object to have better assertions.

I do something like that now :

MyClass myClass = new MyClass().setA(1).setB("foo").setC(true);
...
Insert.insertInto("class")
.columns("a","b","c")
.values(myClass.getA(),myClass.getB(),myClass.getC())
.build();

Because in my assertions I can have this :

assertThat(objectReturnedUsingSelectInMyCode).isEqualTo(myClass);

I made this PR to have this :

MyClass myClass = new MyClass().setA(1).setB("foo").setC(true); 
...
Insert.insertInto("class")
.columns("a","b","c")
.object(myClass)
.build();

[jnizet]

I understand your motivation, but this would make DbSetup much more complex and would slowly change it to some kind of ORM, needing all kinds of choices to be made:

• should fields or bean properties (i.e. getters) be mapped to the database?
• how to respect Java naming conventions and DB name conventions: shippingAddress should be mapped to SHIPPING_ADDRESS?
• should associations between objects be mapped?
• how to integrate this with generated values?
• ...

I'd prefer not to embed this in DbSetup. You could add a Map<String, Object> toDbSetupMap() method to your class and simply do

insertInto("class")
    .columns("a","b","c")
    .values(myClass.toDbSetupMap())
    .build();

[PierreLeresteux]

Hi and thanks for your reply ...

I understand your point of view and I'm agree, I'll try to use your recommandation. :v:

Have a nice day.