search

Ninjabrain1 / Ninjabrain-Bot

Accurate stronghold calculator for Minecraft speedrunning.
345 stars 50 forks source link

suggestion - option to disable the +0.5 added to x and y coords in pre-1.13 #74

Closed tildejustin closed 3 months ago

tildejustin commented 1 year ago

relevant source: https://github.com/Ninjabrain1/Ninjabrain-Bot/blob/ccbaa72d51ef4cccc7945b06f9ce4ac8d58a51db/src/main/java/ninjabrainbot/model/datastate/endereye/InputData1_12.java#L18-L19 Allows more precision in measuring, I don't think there's any issues with this?

Ninjabrain1 commented 1 year ago

I don't think it will add much, the limiting factor in pre 1.13 is the angle precision, only having one decimal, not the precision in x and z. Inputting decimals for the coordinates will barely improve the accuracy, and I'm pretty sure it's just wasted time.

tildejustin commented 1 year ago

image only one test, will do more, but gave a 5% increase in confidence after two eyes, 2% loss after one eye (std 0.01, proper pixel measured (with 1.16 standards, I was told it was different in 1.12 but not how to account for that so...))

another test, was third offset (7.1%) on my version and not on v1.4.1 at all after first eye image

tildejustin commented 1 year ago

I think I may have messed up the first one, never used this before :P

tildejustin commented 7 months ago

implemented in https://github.com/tildejustin/ninjabrain-bot/commit/9e3d7337b58b4e2803fac0763da1ec3af3139614