Ninjdai1 / letsdo-addon-compat

Adds compatibility between Dehydration and the let's do mods so you don't have to
3 stars 3 forks source link

Haunted Harvest succotash recipe isn't tagged properly #1

Closed ZachsRoom closed 6 months ago

ZachsRoom commented 6 months ago

Succotash's recipe is missing an ingredient in meadow's cooking pot and it's also not using ingredient tags either image image image

ZachsRoom commented 6 months ago

image I used a datapack to change forge: tags to c: tags and it seems to be fixed I've also noticed that every recipes that use corn just turn into corn dough from cultural delights

Ninjdai1 commented 6 months ago

Could you send your modlist ? I currently do not change tags, except for knives and cheese. I'm working on fixing the fabric compat with c: tags, but that's mostly an issue with the mods that don't add it themselves, unless there's a way to automate it.

I don't know where the corn dough issue comes from, I'll look into it if I can reproduce it

ZachsRoom commented 6 months ago

Here's my mod list

Ninjdai1 commented 6 months ago

Can you try using the latest version (located at https://github.com/Ninjdai1/letsdo-addon-compat/releases) ? I made separate forge/fabric versions, this should help with a lot of tag issues

Edit: After testing, it indeed fixed the succotash recipe, and probably most if not all similar issues Please check if the corn dough issue remains, and if not I'll close the issue as resolved

ZachsRoom commented 6 months ago

I tried the latest version and the tags look good now :D Also, I think recipes with only one ingredient is the cause. Normally without compat mod this recipe produce 2 bowl image image

Ninjdai1 commented 6 months ago

I might have forgotten a count field in an output in the generation code, I'll look at it :) Thanks for submitting this issue, it actually made me fix a lot of bugs !

ZachsRoom commented 6 months ago

Happy to help!