Ninjdai1 / letsdo-addon-compat

Adds compatibility between Dehydration and the let's do mods so you don't have to
3 stars 3 forks source link

Wrong tags list I saw (forge mod) #6

Open KingSejong25 opened 5 months ago

KingSejong25 commented 5 months ago

image image Chunk nugget(Delightful mod's food) ▶ Recipes used

=================================================

image image raw_pasta item tag, a lot of pasta recipe's ▶ Recipes used

Example picture's food is Cheese pasta in Vintage Delight.

P.S.) This mod is not in the list of compatible modes, but I added it because the recipe exists. Because Recipes from other compatible modes have the same problem.

=================================================

image image raw_rabbit tag in rabbit stew recipes ▶ Recipes used

=================================================

image image Coconut curry(Delightful mod's food) ▶ Recipes used

=================================================

image image image Lasagna([Let's do] Candlelight mod's food ▶ Recipes used

P.S.) I don't know if it's a problem with this mod, but I added it temporarily.

=================================================

image image Pineapple Fried rice(Pineapple Delight mod's food) ▶ Recipes used

=================================================

image image Phantom puff(Casualness Delight mod's food) ▶ Recipes used

P.S.) This mod is not in the list of compatible modes, but I added it because the recipe exists.

=================================================

image image Azalea Tea(Delightful mod's food) ▶ Recipes used

=================================================

These are all I've seen. Most errors occur in raw_pasta tag.

My English is not good. Because I am Korean and this was helped by the translator. (a little!) I'd appreciate it if you could check it out and tell me what you don't understand. Thanks!

Ninjdai1 commented 5 months ago

Hi, Thanks for reporting all these ! Could you try the development version and confirm these issues still appear with it ?

Thanks ^^

KingSejong25 commented 5 months ago

I checked it out. There doesn't seem to be much difference.

Additionally, I found one more new problem.

image image Added by [Let's do] Meadow mod's cooked rabbit recipe ▶ Recipes used

wasdspace commented 5 months ago

Additional informaltion on forge side, all the recipes use Tag seem to be corrupted. For example, if you craft recipes with water, the create's recipes would be {"amount": xx, "fluid": "minecraft:water", "nbt": {}}, but this mod uses "FluidTag:forge:water". in addition, a good chunk of the Tags use "c: xx" instead of "forge: xx", which leads to quite a lot craft errors. Of course, even if some of them are using "forge:xx", there are also a lot tag errors. Sadly this mod is almost unplayable on the forge environment

wasdspace commented 5 months ago

2024-06-27_20 23 23 2024-06-27_20 23 32 2024-06-27_20 23 33

KingSejong25 commented 5 months ago

I don't know about Create mod. Because I didn't use that mode. If there's the same thing, I use Forge too.

The pictures above are all I've seen.

https://www.curseforge.com/minecraft/mc-mods/lets-do-addon-fluids Have you ever used this?

wasdspace commented 5 months ago

Yes but it shouldn't matter. To test I downloaded Farmers Delight, Create and Lets Do Series and Ninjdai1's mods

Ninjdai1 commented 5 months ago

I mainly test on fabric, so I let quite a few tags error on forge slip I'll fix all the reported ones, except rottenleather:sweetened_chunk as it's not a mod the compat addon impacts

Ninjdai1 commented 5 months ago

Additional informaltion on forge side, all the recipes use Tag seem to be corrupted. For example, if you craft recipes with water, the create's recipes would be {"amount": xx, "fluid": "minecraft:water", "nbt": {}}, but this mod uses "FluidTag:forge:water"

@wasdspace The FluidTag is used as that's what create uses aswell, I'll fix it

As for the forge: tags that don't work, can you check out the indev build and confirm the issues are still happening ? Thanks for your reports, it really helps !

KingSejong25 commented 5 months ago

@Ninjdai1 Thanks! But rottenleather:sweetened_chunk is not the mode installed on my side either. I don't know why this tag is here.

druidicmage commented 4 months ago

Not sure if anything here has been fixed, but on forge 1.20.1 (version 1.4.2) there are still issues image image image

Edit: Milk is also broken as well