search

NinoSkopac / PhpTikaWrapper

Simple PHP Wrapper for Apache Tika
60 stars 24 forks source link

update symfony #19

Open youngbobby opened 5 years ago

youngbobby commented 5 years ago

Update Symfony/process to fix conflict with Laravel

NinoSkopac commented 5 years ago

Hello and thank you. I’ll review this tomorrow (this requires a version bump to >=7.2) and release a new minor(major?) version.

youngbobby commented 5 years ago

I'm not sure. Laravel does require >=7.2 at the moment anyway. Please let me know your findings.

NinoSkopac commented 5 years ago

After this is merged and released, minor version will be bumped (https://blog.whiteoctober.co.uk/index.html%3Fp=3415.html)

NinoSkopac commented 5 years ago

@youngbobby I've just pushed a commit with proper PHP and PHPUnit versions, however, I'm unable to get the tests running.

Running ./vendor/bin/phpunit returns No tests executed! - I need the tests to pass before merging.

Can you assist?

youngbobby commented 5 years ago

Very weird. I experience the same issue too.

youngbobby commented 5 years ago

Any update with this ?

I really need to use this awesome package.

NinoSkopac commented 5 years ago

No, I never got down to figuring this out, so it's stuck.

youngbobby commented 5 years ago

Any idea how I can install manually like from this issue https://github.com/NinoSkopac/PhpTikaWrapper/issues/1 ?