NiranjanKumar001 / iPhone-16-Pro-Clone

Explore this sleek and first website clone of the iPhone 16 Pro! Built with React.js for an interactive feel, Three.js for stunning 3D visuals, and GSAP for smooth animations. IMPORTANT: Star the repo as you about contribute to the open source ,and this will work as a bookmark.
https://i-phone-16-pro.vercel.app
Other
13 stars 16 forks source link

floating navbar made responsive using hamburger #37

Closed ParvamShah1 closed 1 month ago

ParvamShah1 commented 1 month ago

Updated Pull Request with Major Revisions

Hi @NiranjanKumar001 ,

I hope you're doing well. Following your feedback on my previous pull request, I've made substantial updates to address all the points you raised. I've carefully reviewed and revised the code to ensure it aligns with the project requirements and coding standards.

Please consider this updated pull request for review. I appreciate your time and feedback, and I look forward to hearing from you.

Thank you for your consideration! issue #29 . Best regards,

Here are few images for your reference,

image image
vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-phone-16-pro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:20pm
NiranjanKumar001 commented 1 month ago

Screenshot 2024-10-13 174304 Screenshot 2024-10-13 174319 you fixed for smaller devices but messed larger one . @ParvamShah1

ParvamShah1 commented 1 month ago

Hi @NiranjanKumar001 , As you asked i have updated the desktop view as it was before and hamburger will work the same way as it worked before . Please review the changes and consider merging my pull request ,there have been a lot of efforts into this. Sorry for the inconvenience. Thanks for your patience and consideration.

Here are few images for your reference ,

image image
NiranjanKumar001 commented 1 month ago

@ParvamShah1 Crazzy after so many rejection didnt gave and finally did it .GREAT !!

ParvamShah1 commented 1 month ago

Thanks for your cooperation !