search

NirantK / Hinglish

Hinglish Text Classification
MIT License
30 stars 10 forks source link

Reorganise the Repo #55

Open NirantK opened 3 years ago

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

meghanabhange commented 3 years ago

Also, @NirantK when reorganising a lot files will break because of the file paths. Currently They have data_path like 


data_raw = datapath/"raw"
data_interim = datapath/"interim"
data_processed = datapath/"processed"
cleanlab_datapath = datapath/"cleanlab"```

So this might require changes.
meghanabhange commented 3 years ago

Also, notebooks like nbs/07_Transformers.ipynb will break because it's importing from the scripts like from hinglishutils import get_files_from_gdrive so the imports would also require changing and jupyter notebook acts very moody with parallel directory imports.