search

NirmalScaria / le-git-graph

Browser extension to add git graph to GitHub website.
https://chrome.google.com/webstore/detail/le-git-graph-commits-grap/joggkdfebigddmaagckekihhfncdobff
MIT License
3.15k stars 16 forks source link

Commits tab removed when using browser's back button #23

Open russellbanks opened 1 year ago

russellbanks commented 1 year ago

Going into another tab on GitHub and returning (by using the Browser's back button) removes the commits tab. In some cases, the Commits tab does not get removed, but rather the button will not work anymore until the page is refreshed. This was tested on Firefox.

firefox_d29erXJv1o

BitBlitObviMormon commented 1 year ago

I can confirm this on Chrome. I figured it was just the website cache doing goofy things (since a hard reload fixes it).

BitBlitObviMormon commented 1 year ago

It also appears to happen when navigating around GitHub. For instance, if you view GitHub's commit history (not the extension's) and then click the "Older" button to view older commits then the extension's commit tab disappears on Chrome (Edit: This is inconsistent, sometimes it works as normal). Refreshing the page or traveling to the page directly (via url or link) appears to work around this issue.

NirmalScaria commented 1 year ago

Honestly I have zero idea why this happens. And I guess this has more to do with the original GitHub page code rather than the extension code. And considering how simply refreshing the page will fix the issue temporarily, I'm thinking about postponing this issue, unless someone would like to step in. Not exactly "wont-fix". Not "under-progress" either. @BitBlitObviMormon @russellbanks