NirmalScaria / le-git-graph

Browser extension to add git graph to GitHub website.
https://chrome.google.com/webstore/detail/le-git-graph-commits-grap/joggkdfebigddmaagckekihhfncdobff
MIT License
3.13k stars 16 forks source link

Commit status icon incorrect #55

Closed CC007 closed 9 months ago

CC007 commented 10 months ago

Describe the bug The Le Git Graph commit graph page shows commit status checkmarks, Even when the commit status should indicate failed or absent. When clicking on the checkmark for these commits, it does display correctly that the checks have failed.

To Reproduce Steps to reproduce the behavior:

  1. Go to a repo (a private repo in my case, using fine grained personal access tokens with metadata, content and commit status permissions)
  2. Click on the 'Commits' tab
  3. Look to the right of the commit date
  4. See the wrong commit status

Expected behavior I expect commits with failed checks to show an ❌ and commits without any checks to not show a ❌ or ✔ at all

Screenshots Le Git Graph commit graph page with wrong status: afbeelding And: afbeelding

Commit page with correct commit status: afbeelding

Version information:

Additional context As said above, I was using a new fine grained personal access token with metadata, content and commit status permissions with read-only access. I don't know if this has anything to do with the bug, but I'm mentioning this here just to be sure