search

Nirmaleshwar / pe

0 stars 0 forks source link

Deletion of days doesn't work properly #3

Open Nirmaleshwar opened 2 years ago

Nirmaleshwar commented 2 years ago

I added 2 days to my trip and when I gave the command to delete day 0, it deleted day 1 instead. Day 0 is still visible when I use the view all command. This is quite a big issue as you mentioned that deletion is irreversible in your UG.

Screenshot 2021-11-12 164134.png

nus-pe-bot commented 2 years ago

Team's Response

Actually the day which is deleted is day 0 and the index of other days will go forward automaticly. Hence, after you delete day 0, the previous day 1 will change to day 0

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Your UG doesn't specify anywhere that deleting moves the index forward. Besides what is the point of doing this? If let's say I did activities like so:

1) Day 0: Activity 1 2) Day 1: Activity 3 3) Day 2: Activity 4

If I were to give your delete day 0 command, it will index everything forward and my Activity 4 that was initially stored under day 2 is lost completely. If the user let's say due to some reason wants to delete the activities in Day 2 simply because nothing happened on day 2 then they should do so without changing the index of the other days as this can be quite confusing. Perhaps again you know this to be true as you made the product but, users may be in for a rude surprise when they see their days getting indexed differently from what they remembered. Plus, again there is no mention of this in the UG so users will have absolutely no clue on what happened.