search

Nirmaleshwar / pe

0 stars 0 forks source link

Deletion of item not working properly #4

Open Nirmaleshwar opened 3 years ago

Nirmaleshwar commented 3 years ago

I had initially added items to Day 28 and Day 0 as can be seen in the picture labelled "2359: stuff". When I deleted day number 0 however, it deleted Day 28 and the item it had previously, was transferred to Day 27. I feel like this is a very massive flaw as a user can easily mess up their list with this Day 0 delete bug.

Screenshot 2021-11-12 165416.png

nus-pe-script commented 2 years ago

Team's Response

The item does not transfer to day 27, that is because after user delete day 0, the previous day 1 will become the first day which is day 0, then the previous day 28 will change to day 27. We do not want to see that there are only 28 days in list but there is a day 28 in the list

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Deletion of days doesn't work properly

I added 2 days to my trip and when I gave the command to delete day 0, it deleted day 1 instead. Day 0 is still visible when I use the view all command. This is quite a big issue as you mentioned that deletion is irreversible in your UG.

Screenshot 2021-11-12 164134.png

[original: nus-cs2113-AY2122S1/pe-interim#604] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Actually the day which is deleted is day 0 and the index of other days will go forward automaticly. Hence, after you delete day 0, the previous day 1 will change to day 0

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I have mentioned the same problem earlier but there is no mention of this anywhere in your UG and thus, the user can very easily use the product in the wrong way as your delete function is not explained clearly.