nus-se-script
commented
2 years ago Team's Response
If that is what you entered as a trip name then that means you wanted that as a trip name. If you wanted more spaces in between words then it is not our place to modify that for you.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: You are program can easily become extremely faulty as it fails in the aspect of duplicate detection. If I enter the same name but with a lot of spaces in between one of the inputs, then your program still accepts them as two unique inputs. Currently, your program only uses simple/value matching to detect duplicity. If your program at least warned against such detection that two inputs might be similar in value, then I will rescind the bug. However, your program doesn't even do that. Moreover, this was just a simple test where I put a lot of spaces between the words. If I were to just add three spaces (for e.g. John___ Doe) and another entry with only one space (for e.g. John_Doe), your program will still accept the two trips as unique. Then, it is definitely in your place as the developers to watch out for such issues. Here is a screenshot of this very issue detailed on the module website:
Although your program trims trailing or leading spaces, there is no safeguard in place for spaces in between words. I assume since, in your UG, your trip name is specified as "trip_name", you'll be using underscore to separate strings for a trip's name. But it is not the case (as seen in the first trip's name).
This can result in allowing users to enter some very erroneous names.