Nirmaleshwar / pe

0 stars 0 forks source link

shortest-cost command doesn't make sense #9

Open Nirmaleshwar opened 2 years ago

Nirmaleshwar commented 2 years ago

Just like shortest-path, I don't get what the point of this feature is. Is the cost 2 SGD? 2 RMB or is it indicating something else other from cost?

Screenshot 2021-11-12 171441.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Currency for shortest cost not mentioned

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


For the shortest-cost command the UG does not give the currency for the values shown to the user


[original: nus-cs2113-AY2122S1/pe-interim#2038] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Never intended to put currency, as it would add additional need to convert currency.

Whose currency should it be? home or foreign, unable to determined hence not implementing

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is not a duplicate issue. I wasn't particularly concerned about the need for currency symbols but instead on what exactly "2.0" means in the output. As otherwise, your feature doesn't really help the user find the "cost" of the trip. You can't expect the user to understand if the 2 could mean 2 SGD to for a trip to China or 2 RMB for a trip from China to Singapore etc. It is very ambivalent.


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: This is most definitely not a documentation bug. There isn't some minor cosmetic issue or unclear UG description for this. In fact, there is both a very useless description for this feature and the feature adds absolutely no value to the product. My reason for this is that although I understand the utility of knowing what the cost of a trip is to another country, the feature is not fully realized or it is incomplete. By simply telling me that a trip is "2.0" there is literally nothing I can gain from it.

If instead, you told me that the cost is 200 SGD for a one-way trip to China or something along those lines then it'll help the user in planning their trip out as that is the intended purpose of this feature. This feature instead seems like something that you came up with at the last minute without properly thinking about its use. If you are going to talk about costs, then currency symbols are necessary to make sense of it. Otherwise, it doesn't add any value.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I would say this is still medium as it is just some extraneous function that isn't crucial to the functioning of the product but, for a user that is concerned about saving money on their trips (as mentioned in your user stories) then this feature fails to achieve that. There is no useful conversion or meaningful rates here that can help users make better money-driven decisions. Is just a random number that makes no sense. You also haven't explained anything about this to the user in the UG so again, completely useless.