Nirvik07 / FIFA_WORLD_CUP_2022

FIFA WORLD CUP 2022

MIT License

8 stars 17 forks source link

Improved Navbar and footer #15

Closed itshypon closed 2 years ago

itshypon commented 2 years ago

Pull Request for FIFA WORLD CUP 2022

Issue Title : Improved Navbar, footer and minor changes

Info about the related issue (Aim of the project) : Aim of the project is to give a better looking website
Name: Himanshu
GitHub ID: https://github.com/itshypon
Idenitfy yourself: Hactoberfest Participant

Closes: #9 number that will be closed through this PR

Describe the add-ons or changes you've made 📃

I have added navbar using bootstrap and did some changes in footer to make it look a little better. I changed font of some text to Montserrat and did a little change in one button.

Nirvik07 commented 2 years ago

@itshypon please follow PR template in the repo for creating a pr.

itshypon commented 2 years ago

@Nirvik07 Done

Nirvik07 commented 2 years ago

@itshypon follow this file https://github.com/Nirvik07/FIFA_WORLD_CUP_2022/blob/main/.github/PULL_REQEUST_TEMPLATE/pull_request_template.md

itshypon commented 2 years ago

@Nirvik07 Done, Edited my PR

itshypon commented 2 years ago

@Nirvik07 When will this get merged or get 'hacktoberfest-accepted' label?

Nirvik07 commented 2 years ago

@itshypon did you create the pull request in projects folder?

itshypon commented 2 years ago

@Nirvik07 No, I just did pull request directly without any change so I guess it should be in main directory.

Nirvik07 commented 2 years ago

@itshypon no please PR it to the projects folder means upload your whole project in Projects Folder through Pull Request. Otherwise my code will get deleted.

itshypon commented 2 years ago

@Nirvik07 These branches are available, to which branch should I send PR?

Nirvik07 commented 2 years ago

@itshypon you will create your own branch. I will merge to the main branch.

Nirvik07 commented 2 years ago

@itshypon if you are facing any problem, contact me in discord. Discord Id: babe07#7187