Nirvik07 / FIFA_WORLD_CUP_2022

FIFA WORLD CUP 2022
MIT License
8 stars 17 forks source link

Add/aboutus #21

Closed appledora closed 2 years ago

appledora commented 2 years ago

Issue Title : CREATE AN ABOUTUS PAGE

Closes: #6

Describe the add-ons or changes you've made 📃

appledora commented 2 years ago

@Nirvik07 please check

Nirvik07 commented 2 years ago

@appledora please follow this file https://github.com/Nirvik07/FIFA_WORLD_CUP_2022/blob/main/.github/PULL_REQEUST_TEMPLATE/pull_request_template.md for creating Pull Request.

Nirvik07 commented 2 years ago

@appledora please pr the file in Project Folder.

appledora commented 2 years ago

@Nirvik07 I will modify the pr according the https://github.com/Nirvik07/FIFA_WORLD_CUP_2022/blob/main/.github/PULL_REQEUST_TEMPLATE/pull_request_template.md. But i am confused about what you meant by PR the file in the project folder. I created a folder inside the Project folder and kept my asssts and code inside it

Nirvik07 commented 2 years ago

@appledora I want to tell you that did you uploaded your project in Projects Folder?

appledora commented 2 years ago

Yes,you can check the commit changes.

Nirvik07 commented 2 years ago

@appledora if possible keep the Screenshot in description of PR details.

appledora commented 2 years ago

oh, i removed it because it wasn't in the PR template. adding

Nirvik07 commented 2 years ago

@appledora don't edit the index.html. if possible, create a new index.html and put it inside your folder in the project folder, otherwise leave to me and delete the index.html in your PR.

appledora commented 2 years ago

@Nirvik07 undid changes to index.html.

Nirvik07 commented 2 years ago

@appledora delete your index.html

appledora commented 2 years ago

@Nirvik07 check now

Nirvik07 commented 2 years ago

@appledora check everything and if you face any problem, ping me in discord. Discord Id : babe07#7187