search

NiryoRobotics / niryo_one_ros

Niryo One ROS stack
GNU General Public License v3.0
236 stars 160 forks source link

Adding EXECUTE TRAJ to the robot comannder #4

Closed smaassen closed 6 years ago

smaassen commented 6 years ago

I think this is a nice way to keep the code in high level format and it makes it possible to check the incoming trajectory before executing (these checks have to be defined yet)

renarded commented 6 years ago

Hi smaassen,

Thank you for this contribution !

Before reviewing and merging, I would ask you to break this PR into several PR :

The _one missing on srdf has already been fixed here

And the STL files will be shortly updated. For now we have only updated the repository with STL files to print (here), we will now update the STL on this ROS repository (collada files for visualisation and simplified STL for collisions)

Best regards, Edouard