Nisbo / another_mvg

MVG/MVV integration for Home Assistant
https://github.com/Nisbo/another_mvg#
MIT License
10 stars 4 forks source link

Version 1.6.0 Pre Info #10

Open Nisbo opened 1 month ago

Nisbo commented 1 month ago

Currently I am working on version 1.6.0 A Beta including screenshots is already https://github.com/Nisbo/another_mvg/releases/tag/v1.6.0.BETA.2

spaceboots23 commented 2 weeks ago

Looking good, please consider adding a configuration field for show destinations, with the opposite functionality of the already existing hide destinations configuration field.

Example usecase: show all regional trains from Ostbahnhof to Hauptbahnhof. Without this, the user would have to hide every regional train that does not have destination hauptbahnhof.

spaceboots23 commented 2 weeks ago

Also, it seems that field names are missing from V1.6.0:B2 when running HA core: 2024.8.3 frontend: 20240809.0

Screenshot from 2024-09-04 15-16-05

Nisbo commented 2 weeks ago

Looking good, please consider adding a configuration field for show destinations, with the opposite functionality of the already existing hide destinations configuration field.

Example usecase: show all regional trains from Ostbahnhof to Hauptbahnhof. Without this, the user would have to hide every regional train that does not have destination hauptbahnhof.

Good idea. But keep in mind, if for instance the train does not end on Hauptbahnhof (like S3 to Mammendorf) you will not see the connection. You have to add every possible end station. I will have a look on it.

Nisbo commented 2 weeks ago

Also, it seems that field names are missing from V1.6.0:B2 when running HA core: 2024.8.3 frontend: 20240809.0

Screenshot from 2024-09-04 15-16-05

Looks like this file is missing https://github.com/Nisbo/another_mvg/blob/v1.6.0-BETA-2/custom_components/another_mvg/translations/en.json or maybe I forgot to update something on git

spaceboots23 commented 2 weeks ago

Looking good, please consider adding a configuration field for show destinations, with the opposite functionality of the already existing hide destinations configuration field. Example usecase: show all regional trains from Ostbahnhof to Hauptbahnhof. Without this, the user would have to hide every regional train that does not have destination hauptbahnhof.

Good idea. But keep in mind, if for instance the train does not end on Hauptbahnhof (like S3 to Mammendorf) you will not see the connection. You have to add every possible end station. I will have a look on it.

Yes, this is the problem I'm trying to solve: being able to filter for connections that stop at a particular station, but don't necessarily terminate there. Basically what I'd like to achieve is some sort of Stammstrecke funcitonality, where for any given station you can easily see what the next train to the city is. Which is achievable with the negative filtering, but would be much quicker to setup with a positive filter (and be more likely to catch all connections).

I'm guessing this might be due to an API limmitation?

Either way, nice work on the integration, it's great!

spaceboots23 commented 2 weeks ago

Looks like this file is missing https://github.com/Nisbo/another_mvg/blob/v1.6.0-BETA-2/custom_components/another_mvg/translations/en.json or maybe I forgot to update something on git

Confirmed new file fixes the rendering :+1:

Nisbo commented 2 weeks ago

Looking good, please consider adding a configuration field for show destinations, with the opposite functionality of the already existing hide destinations configuration field. Example usecase: show all regional trains from Ostbahnhof to Hauptbahnhof. Without this, the user would have to hide every regional train that does not have destination hauptbahnhof.

Good idea. But keep in mind, if for instance the train does not end on Hauptbahnhof (like S3 to Mammendorf) you will not see the connection. You have to add every possible end station. I will have a look on it.

Yes, this is the problem I'm trying to solve: being able to filter for connections that stop at a particular station, but don't necessarily terminate there. Basically what I'd like to achieve is some sort of Stammstrecke funcitonality, where for any given station you can easily see what the next train to the city is. Which is achievable with the negative filtering, but would be much quicker to setup with a positive filter (and be more likely to catch all connections).

I'm guessing this might be due to an API limmitation?

Either way, nice work on the integration, it's great!

You are right, in the API there is no functionallity for "stadteinwärts" or something like that. This was the reason why I created the "hidestation feature". However, I think I can implement your request.

spaceboots23 commented 2 weeks ago

Looking good, please consider adding a configuration field for show destinations, with the opposite functionality of the already existing hide destinations configuration field. Example usecase: show all regional trains from Ostbahnhof to Hauptbahnhof. Without this, the user would have to hide every regional train that does not have destination hauptbahnhof.

Good idea. But keep in mind, if for instance the train does not end on Hauptbahnhof (like S3 to Mammendorf) you will not see the connection. You have to add every possible end station. I will have a look on it.

Yes, this is the problem I'm trying to solve: being able to filter for connections that stop at a particular station, but don't necessarily terminate there. Basically what I'd like to achieve is some sort of Stammstrecke funcitonality, where for any given station you can easily see what the next train to the city is. Which is achievable with the negative filtering, but would be much quicker to setup with a positive filter (and be more likely to catch all connections). I'm guessing this might be due to an API limmitation? Either way, nice work on the integration, it's great!

You are right, in the API there is no functionallity for "stadteinwärts" or something like that. This was the reason why I created the "hidestation feature". However, I think I can implement your request.

Sounds good, I have some time in the next few weeks, so if I can wrap my head around your code I'll have a look too.

Nisbo commented 1 week ago

Your request regarding the destinations was implemented locally

grafik