In VSCode themes can "extend" other themes. It is done by include field in the extending theme.
monaco-vscode-texmate-theme-converter ignores this field.
In case of convertTheme there is no other possibility (extended theme file path is relative to extending theme file path, and we do not know path of extending theme file path — we only know its parsed content).
But in case of convertThemeFromFilePath and convertThemeFromDir we are able to handle the include field.
We should handle include field, or at least warn (in docs/README/etc.) that include field should be handled by the user of the library.
sidwebworks
commented
2 years ago
In VSCode themes can "extend" other themes. It is done by
includefield in the extending theme.monaco-vscode-texmate-theme-converterignores this field. In case ofconvertThemethere is no other possibility (extended theme file path is relative to extending theme file path, and we do not know path of extending theme file path — we only know its parsed content). But in case ofconvertThemeFromFilePathandconvertThemeFromDirwe are able to handle theincludefield.We should handle
includefield, or at least warn (in docs/README/etc.) thatincludefield should be handled by the user of the library.