search

NishuGoel / svelte-i18next

Internationalization for svelte framework. Based on i18next ecosystem
https://npmjs.com/package/svelte-i18next
MIT License
51 stars 11 forks source link

does it support sveltekit? #7

Closed sunw31 closed 1 year ago

binajmen commented 1 year ago

Hi @NishuGoel, I have the same question than @sunw31 :)

Are there guidelines when working with SvelteKit and SSR in general?

codenius commented 1 year ago

SvelteKit is out of beta now and released a stable version recently. Because of its benefits in navigation it's used by many people in combination with Svelte. Therefor I want to ask for SvelteKit support of this package again, because it would increase the benefit for many users.

ricardo-rp commented 1 year ago

I think a more specific set of feature requests would be helpful. What features do you expect from a sveltekit integration that the basic integration does not provide?

ehsanonline commented 1 year ago

no it doesn't.

codenius commented 1 year ago

I think a more specific set of feature requests would be helpful. What features do you expect from a sveltekit integration that the basic integration does not provide?

It's more about general compatibility. In the moment the package is misconfigured and throws errors when running with SvelteKit. Check out https://github.com/codenius/svelte-i18next for a fixed version, that works with SvelteKit. I think after some testing it might be ready to merge.

sapkra commented 1 year ago

@codenius Thank you for addressing that issue. Is there any update on this?

@NishuGoel Would you merge and publish a new version if I create a PR for it?

NishuGoel commented 1 year ago

Yes ofcourse! Please go ahead