Nitecon / 1Password-legacy

1Password Linux client.
BSD 3-Clause "New" or "Revised" License
74 stars 8 forks source link

Missing electron-packager dependency #9

Open ukch opened 6 years ago

ukch commented 6 years ago

When trying to build the binary using go:

$ go get -u github.com/Nitecon/1Password
$ cd ~/go/src/github.com/Nitecon/1Password
$ ./build.sh
-->> Cleaning out build dir
-->> Cleaning out dist dir
-->> Installing dependencies
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN 1password@0.1.0 license should be a valid SPDX license expression

+ electron-debug@0.5.2
added 2 packages in 1.244s
-->> Upgrading all modules
--> Building server thread binaries
--> Building Linux 64
-> Building linux/amd64 server thread
-> Building linux/x86_64 application binary
./build.sh: line 20: /home/joel/go/src/github.com/Nitecon/1Password/node_modules/electron-packager/cli.js: No such file or directory
Linux 64bit Binary built: /home/joel/go/src/github.com/Nitecon/1Password/dist/1pass-linux-x64/1pass

No binary is built (notice the error message on the second-to-last line). Adding electron-packager as a dependency in package.json fixes this problem.

Nitecon commented 6 years ago

@ukch would you mind adding a PR for this and I'll be happy to accept it.

gpatkinson commented 6 years ago

I'd appreciate it being integrated into the binary, I'm also getting a blank screen. @Nitecon thanks for all your hard work on this project!