search

Nitjsefni / osmbonuspack

Automatically exported from code.google.com/p/osmbonuspack
0 stars 0 forks source link

class StaticCluster is not visible #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please change visibility of StaticCluster class to public, so it is possible to 
override MarkerClusterer.buildClusterMarker(StaticCluster, MapView) method in 
MarkerClusterer's descendants.

Original issue reported on code.google.com by biegl...@gmail.com on 5 Mar 2014 at 10:23

GoogleCodeExporter commented 9 years ago 
OK. But I'm not sure it will be sufficient for overriding.

Original comment by mathieu....@gmail.com on 6 Mar 2014 at 10:16

GoogleCodeExporter commented 9 years ago 
Committed.

Original comment by mathieu....@gmail.com on 6 Mar 2014 at 9:32

GoogleCodeExporter commented 9 years ago 
Hi,
class StaticCluster is missing public access modifier.

The intention behind this request is that I can handle use cases where markers 
have same geopoints, e.g. by writing code like this:

@Override
public Marker buildClusterMarker(StaticCluster cluster, MapView mapView) {
  Marker m = super.buildClusterMarker(cluster, mapView);
  if (!mapView.canZoomIn()) {
    m.setInfoWindow(...);
  }
  return m;
}

Thank you!

Original comment by biegl...@gmail.com on 7 Mar 2014 at 7:52

GoogleCodeExporter commented 9 years ago 
Sorry, I moved the class in a separate file, but I forgot the modifier! 
Done now.

Original comment by mathieu....@gmail.com on 7 Mar 2014 at 10:03

GoogleCodeExporter commented 9 years ago 
This fix is part of v4.9. 

I also revised the overall Clusterer architecture: there is an abstract 
MarkerClusterer, and a GridMarkerClusterer. So it's easy to subclass and 
override buildClusterMarker. 
Tuto is also added in the Wiki. 
I close this Issue.

Original comment by mathieu....@gmail.com on 17 Mar 2014 at 9:47

GoogleCodeExporter commented 9 years ago 
Again, thank you!

Original comment by biegl...@gmail.com on 18 Mar 2014 at 10:57