Closed SmallGreenET closed 10 years ago
Hi, I've been using the robot plugin for a while, it helps a lot in my daily work. During the usage I got some improvement ideas, especially in the environment I'm using it (a lot of custom keywords and their java implementation, robot and java resources distributed in multiple maven artifacts). I would be glad to do some contributions to your project. I'm new both at GitHub and your project, please be patient with my mistakes. :) Best regards, Peter
Looks great! I will do a proper review as soon as I have the time. Thanks!
Basic idea is good, and it works fine. Some thoughts:
Currently all projects are searched for matching java types; first match is used. In larger projects it's possible that the same type exists in multiple projects, in which case it would be good to perhaps provide all of them as a choice.
Luckily this would be easy to implement - just change getJavaFile() to getJavaFiles() and have it return a list instead. The caller would then just add multiple links to the links
list.
What do you think?
I implemented the changes I suggested and merged the result.
My thought was that only one java class can be picked with the given fully qualified name, so you should not have multiple matching classes in your projects. However we can't ensure that and the proper class will be selected only during runtime, so your correction is fair. Thanks for the improvement and merging the solution!