If somebody first takes license-maintainer into use and installs the pre-commit hook using the provided .githooks/license-maintainer/install, then it is error-prone for that project to later introduce a project-specific pre-commit hook in e.g. .githooks/pre-commit because old users might not notice they need to re-install the pre-commit hook to run from the new location instead.
Therefore it would be better for the provided install script to create a .githooks/pre-commit script which calls .githooks/license-maintainer/pre-commit and install the former as pre-commit hook instead. That can then later be easily customized to meet further project needs without needing re-installation on a per-repository basis.
lalloni
commented
7 years ago
If somebody first takes license-maintainer into use and installs the pre-commit hook using the provided
.githooks/license-maintainer/install, then it is error-prone for that project to later introduce a project-specific pre-commit hook in e.g..githooks/pre-commitbecause old users might not notice they need to re-install the pre-commit hook to run from the new location instead.Therefore it would be better for the provided install script to create a
.githooks/pre-commitscript which calls.githooks/license-maintainer/pre-commitand install the former as pre-commit hook instead. That can then later be easily customized to meet further project needs without needing re-installation on a per-repository basis.