search

Nitrak / Vocal-Raid-Assistant

5 stars 6 forks source link

Add Solar Beam to interrupt list #203

Closed Nitrak closed 7 months ago

Nitrak commented 1 year ago

This should already be caught by spell_interrupt, but not when it fails to interrupt?

Investigate.

nyy23 commented 1 year ago

Just tested this ingame.

Actually had to log onto my druid alt - which was an awful experience - and spec into balance -which was an even more awful experience. Exactly as you wrote: We catch the spell_interrupt event. If solar beam actually interrupts, this is perfectly handled by the addon. If you cast solar beam without actually interrupting sth, you wont hear the interrupt sound.

Would close this.

nyy23 commented 1 year ago

Working as intended.

Nitrak commented 1 year ago

False, it announces if you interrupt your target, but if your silence interrupts a separate monster "Interrupted" is not called.

Example 2 mobs, A and B A is casting B is not casting

IF Solar Beam A Then A is interrupted and sound is played. If Solar Beam B while A is casting Then A is interrupted and no sound is played.

Sound should be played in both instances.

Nitrak commented 1 year ago

Either we can track SPELL_INTERRUPT and SPELL_CAST_FAILED, but it will also announce interrupts for other sources (Knockback etc) which while it's true can be misleading.

Or we can add a special case to Solar Beam since it's the only ability functioning like this. (This is probably the most "correct", but also ugly thing to do).

Or we can re-add it to the Druid spell-list again.

nyy23 commented 1 year ago

I would say the primary use case for this is to quickly "get an overview" of whether kicks are being used - or not. When Solar Beam "passively" interrupts, we don't necessarily need to play a sound.

Nitrak commented 1 year ago

I would say, for that exact reason, that we should play a sound when Solar Beam "passively" interrupts because it could just be how someone interrupts if you see the casting target is within range of your active target. The only thing to be mindful of is not screaming out 20 "interrupt" sounds because Solar Beam interrupted 20 spells. We should just output "Interrupt" once.

I agree that we should not announce "interrupt" on every stop-cast (Knockback, Stun, etc).