search

NitroCSIA / nitrocsia-xbmc-addons

Repository for all XBMC addons
5 stars 1 forks source link

Parse season/episode number #2

Open curtisgibby opened 5 years ago

curtisgibby commented 5 years ago

From the Kodi forum:

I've been using this addon for years and love it. I use it to watch Studio C all the time.

It's too bad that the BYU TV API doesn't provide episode numbers within seasons, like "Episode 10" or something like that for S05E10. I need this data in order to push the information into Trakt.tv to scrobble my watches.

I've come up with a hack based on a regex match of the episode's name. For the majority of Studio C episodes, the episode name is simply of the format "Season 5, Episode 10", which works perfectly. But they also have a few themed episodes with titles like "Season 6 Valentine Special" that are actual episodes, taking the place of "Season 6 Episode 12". That title doesn't match the regex, therefore it doesn't get pushed into the video data.

Theoretically you could just use the index of the episode within the season to determine the episode number, but they also have specials that are like clip shows, interspersed throughout the seasons, that they don't count in their numbering. It's a bit of a mess right now.

Anyway, if you think that my little hack would be helpful for someone, I can do a Pull Request on your GitHub repo to add it.

This is not working on the new version of the BYU TV API yet (I want to get #1 merged first), but I can fairly easily reproduce my fix.

NitroCSIA commented 5 years ago

This is great! Pull request away.

curtisgibby commented 5 years ago

To prevent merge conflicts and other problems, I'd rather get #1 merged into the master branch before I start work on this issue. Can you take a look at that PR? Thanks!