search

Nitrokey / fido-authenticator

FIDO authenticator Trussed app.
Apache License 2.0
4 stars 0 forks source link

Remove cbor_serialize_message helper #106

Closed robin-nitrokey closed 5 days ago

robin-nitrokey commented 6 days ago

The cbor_serialize_message helper mixed re-exports of cbor-smol from trussed and ctap-types. This can be problematic if both select different versions. It could be fixed by keeping both in sync, but to avoid this problem entirely, we can also just use cbor_serialize_bytes from Trussed directly.

robin-nitrokey commented 5 days ago

For fido-authenticator, it’s not a problem because we don’t really care about the duplication when working on the crate. And for the final firmware, we can spend more effort to make sure to select the proper versions. The current situation means that a duplication in the locked versions for fido-authenticator leads to compiler errors.