Correct version getter for QMake build

Nitrokey / libnitrokey

Communicate with Nitrokey devices in a clean and easy manner

https://nitrokey.com/

GNU Lesser General Public License v3.0

65 stars 34 forks source link

Correct version getter for QMake build #119

Open szszszsz opened 6 years ago

szszszsz commented 6 years ago

Add get_major_library_version and similar symbols to QMake build. Nitrokey App build done via QMake fails currently.

Connected: #117

robinkrahl commented 6 years ago

It is also possible to define a new compiler that just runs sed to replace the placeholders in version.cc.in. See the Advanced Usage: Adding Compilers section in the qmake manual.

You can find an example implementation on my qmake-version branch. I’m just not sure whether you expect qmake to run on Windows and whether we can rely on sed being available.

szszszsz commented 6 years ago

Temporarily fixed via constants with https://github.com/Nitrokey/libnitrokey/commit/cdd155eacb37c9ce513ddfe6eee692b189de2f2c