Closed sosthene-nitrokey closed 9 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
13fa492
) 0.00% compared to head (1defba0
) 90.36%.
Files | Patch % | Lines |
---|---|---|
pkcs11/src/backend/session.rs | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I tested this patch and confirmed that it can list certificates uploaded using a different mechanism, and that certutil cannot add certificates.
This PR contains 2 changes:
CKA_SERIAL_NUMBER
attribute to certificate objects.fetch_all_keys
request caching a subset of all objects, using only the kind that was first requested.This doesn't fix the certificate upload part of #183, but that cannot be fixed without support for certificates without associated private keys.
This does fix certificate listing with
certutil
mentionned in #187.