Closed comio closed 6 years ago
Hi! You have marked one of the commits as WIP - should I wait with merge?
Wait. I still haven't received the my nitrokey pro :'( and I cannot check and validate the translation.
I will squash the commits into just one at the end.
Ciao
Luigi
@szszszsz
Nitrokey Pro is in my hands. Give me this weekend to check again (I already had yesterday). Side note can you merge also #348 ?
ciao
luigi
Great! Sure! Sorry for delay. It should be merged this week.
Hi @szszszsz
If you want, you can merge this PR. There are bugs into the code that doesn't permit to translate the menu bar/tray menu. I think that main() and MainWindow should be refactored to cover these issue.
ciao
luig
Thank you!
I will check it. Do you suspect the source of the bug (for quick start)?
Just a sanity check - have you run lupdate
and lrelease
before tests?
I haven't... ops
I will do :)
ciao
luigi
lupdate & lrelease done.
You can merge (after your review).
ciao
luigi
Thank you once again!
Dera All,
I'm providing you the Italian translation as is. I'm sorry but I have not still reviewed because I haven't my Nitrokey Pro yet (out of stock :sad:) and I cannot navigate into the gui to check the translation quality (the main problem is the italian produces longer sentences w.r.t. english).
Furthermore I haven't Nitrokey Storage and I cannot validate for this use case.
I will propose in the future a new PR with the translation reviewed.
Final note: on my setup I need to include PR #346 in order to see the translated strings.
I hope in your feedback.
Luigi