Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
288 stars 55 forks source link

Minor language change and typo #360

Closed alex-nitrokey closed 6 years ago

alex-nitrokey commented 6 years ago

Hi,

the string is missing the "do" in English and was ambiguous in German.

Kind regards Alex

oderwat commented 6 years ago

I think the sentences could be made better. Explanation in German (because it makes no sense to talk in english about it :)

Ich würde ja "Wollen Sie sie ändern?" oder "Wollen Sie sie jetzt ändern?" nehmen. Unser schönes "gleich" kann ja auch "jetzt" oder "demnächst" heissen.

alex-nitrokey commented 6 years ago

:thinking: da ist was dran... :+1:

szszszsz commented 6 years ago

Hi! Is this one ready to merge?

alex-nitrokey commented 6 years ago

Sure. But I don't know about this travis check failure. This should be connected to the translation of english string. You know what you have to do with that? If so, merging is fine :+1: