search

Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
287 stars 55 forks source link

Does this work with libnitrokey 3.4.1? #381

Open benoliver999 opened 5 years ago

benoliver999 commented 5 years ago

The README states that you need version 3.3 of libnitrokey yet the latest release is 3.4.1 - is this just an outdated readme or does it genuinely not work? I am trying to use nitrokey-app 1.3.2.

szszszsz commented 5 years ago

Hi! This is a minimal required version of libnitrokey, sorry for confusion. Do you experience issues with such tandem? What is your OS?

Edit: CMake does the check while compiling: https://github.com/Nitrokey/nitrokey-app/blob/d6fad2bd1aecbda2e36d4e9873f613ef5bf7649d/CMakeLists.txt#L210

benoliver999 commented 5 years ago

No issues, just trying to clear it up for the AUR, it's causing dependency issues because they thought it had to be frozen at 3.3. Thanks for the pointer!

szszszsz commented 5 years ago

You are welcome! I have corrected the Readme too.

szszszsz commented 5 years ago

Actually I see, that latest NK App is not compiling due to some deprecated API calls. I will correct that in a moment.

milouse commented 5 years ago

Hi!

When it'll works with the v3.4.1 of the lib, please don't forget to update the libnitrokey submodule in this repository to the correct version (or remove the submodule if it is no more used as a reference) and publish a new tagged release.

Thank you very much :)