Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
287 stars 55 forks source link

'Cancel' button hides window unintuitively and close button minimizes window #398

Open muellermartin opened 5 years ago

muellermartin commented 5 years ago

Expected behaviour

The window reappears when the dock icon is clicked after the window is closed.

The window disappears then the 'x' (close) button is pressed.

Current behaviour

When the 'Cancel' button in several window panels is used, the window disappears completely and cannot be brought back by clicking the dock icon for the Nitrokey App. The only way to bring back the window, is to use the tray menu 'Configure' > 'OTP and Password safe'.

Also the current behaviour of the 'x' (close) button in the window title bar is quite uncommon – at least on macOS. Currently it moves the window into the dock which usually is the behaviour of the '_' (minimize) button. The close and minimize buttons therefore do both the same.

Steps for reproduction

Use any 'Cancel' button in the Nitrokey main window.

Click the 'x' (close) button in the title bar of the main window.

Steps

See screencapture:

nitrokey-app-cancel-window-bug

szszszsz commented 5 years ago

Hi! Thank you for the report! Indeed, this behaviour is not intended, and as a whole it should be consistent with the user expectations. This should be fixed in the next release.