Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
287 stars 55 forks source link

No light icon available for dark trays #425

Closed Segaja closed 2 years ago

Segaja commented 4 years ago

Expected behaviour

Have a visible tray icon if you use a tray with black background color.

Current behaviour

You don't see the icon, because the icon is black and the background of the tray bar is also black.

Steps for reproduction

Start the app with icon active on a black tray bar.

anthraxx commented 4 years ago

something like a gradient based icon instead of solid colors would work in basically all environments.

szszszsz commented 4 years ago

@Segaja Thank you for the report! Will take care of it on the next release.

@anthraxx Good idea, but I think it will not look good. Maybe we should consider moving back to red color by default, and allow later to choose white or black.

jans23 commented 4 years ago

Other applications face the same challenge. Perhaps worth looking how they solved it.

Segaja commented 4 years ago

I don't want to push, but may I ask what the ETA is for the next release?

szszszsz commented 4 years ago

The plan is to work on it and release next month. Perhaps it would be possible to release some small fixes earlier (like this issue).

Segaja commented 4 years ago

So it has been three month now and I still don't see a release for this...

Any idea when we can see this live?

alex-nitrokey commented 4 years ago

Same goes for other OSs, of course. Just wanted to mention. https://support.nitrokey.com/t/bug-nitrokeyapp-icon-invisible-in-windows-10-dark-mode/2424

Segaja commented 4 years ago

I guess it is a general issue for dark themed desktop environments.

Segaja commented 3 years ago

So there recently was a new release: 1.4.1.

Why wasn't this included in that release?