Code refactoring - reformat and deduplication

Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)

https://www.nitrokey.com/

287 stars 55 forks source link

Code refactoring - reformat and deduplication #44

Open szszszsz opened 8 years ago

szszszsz commented 8 years ago

Code needs some refactoring:

[ ] reformat - could be done through clang-format, would be great if reformat would be done automatically before each commit (as git hook) or available as run script
[x] deduplication - through numerous tools available (need to choose best)

Any ideas connected with refactoring should be published here.

szszszsz commented 8 years ago

Added duplication report made with Duplo to wiki: https://github.com/Nitrokey/nitrokey-app/wiki After fixing these duplications we can also check other tools.

szszszsz commented 8 years ago

We could also use https://scrutinizer-ci.com/tour/measure-and-improve-code-quality (free for open source projects).

szszszsz commented 8 years ago

Use QSignalMapper to connect password slots in menu and reduce code amount in mainwindow.cpp. https://doc.qt.io/archives/qq/qq10-signalmapper.html http://doc.qt.io/qt-5/qsignalmapper.html

szszszsz commented 7 years ago

Code was heavily refactored in v1.0. App was migrated to libnitrokey and with it duplicated code segments were removed. Code reformat will be done later.