Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
287 stars 55 forks source link

Do not use 0 in the generated temporary password #448

Closed szszszsz closed 2 years ago

szszszsz commented 4 years ago

libnitrokey processes the binary password with strcpy, thus binary 0 might shorten the temporary password. Do not include 0 value in the generated pass to workaround this bug for backwards compatibility.

Connected: https://github.com/Nitrokey/libnitrokey/issues/180

https://github.com/Nitrokey/nitrokey-app/blob/2151df49b5e2dde14861428cbf3cbc1832d39960/src/GUI/Authentication.cpp#L122-L129