bash-completion file can end up being installed into /usr/etc/

Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)

https://www.nitrokey.com/

287 stars 55 forks source link

bash-completion file can end up being installed into /usr/etc/ #453

Closed Polynomial-C closed 3 years ago

Polynomial-C commented 3 years ago

Steps to reproduce:

Make sure you don't have a bash-completion.pc file installed
run cmake with -DCMAKE_INSTALL_PREFIX=/usr (this is what Gentoo ebuild is doing)

Result:

bash-completion file gets installed into /usr/etc/bash_completion.d/

Possible solution:

Let this be overridable by setting (for example) -DBASH_COMPLETION_DIR="/some/path" and only do your path magic when this has not been set by the user.

szszszsz commented 3 years ago

Hi @Polynomial-C !

Thank you for the report! It should be fixed now thanks to @SoapGentoo, with #454. Do you need a quick release for packaging?

SoapGentoo commented 3 years ago

@szszszsz quick release would help us, then I can quickly add it and remove the patches

szszszsz commented 3 years ago

Noted! Should be done in next 24h.

szszszsz commented 3 years ago

Done at https://github.com/Nitrokey/nitrokey-app/releases/tag/v1.4.2 Sorry for the delay!

SoapGentoo commented 3 years ago

Thanks a lot for being so responsive to our requests!