search

Nitrokey / nitrokey-app

Nitrokey's Application (Win, Linux, Mac)
https://www.nitrokey.com/
287 stars 55 forks source link

Old version of cppcodec #494

Open panicgh opened 1 year ago

panicgh commented 1 year ago

nitrokey-app uses a very old version of cppcodec (unreleased/-tagged, a commit from 2016) via a git submodule.

It may be worthwhile to update the git submodule to a later version. For example, I tried the latest tagged version v0.2 (2018) and so far it seems to work just fine. The latest commits are from 2022.

szszszsz commented 1 year ago

Hi! Thank you for checking that out. For our very small use case it was good enough at the time (hex-base32 conversion). Perhaps worth updating in case there were any security updates, otherwise let's use what is proved to be working stably. Leaving open in case there would be another release.