Nitrokey / nitrokey-documentation

User documentation of Nitrokey's products
https://docs.nitrokey.com
33 stars 37 forks source link

Add scaffolding for nitropy documentation #80

Closed robin-nitrokey closed 2 years ago

szszszsz commented 2 years ago

Bump

daringer commented 2 years ago

yeah that's on me, increasing priority ;) will do it tomorrow(tm)

daringer commented 2 years ago

Sooo, yeah looks very good, I love it, two points: 1) consistent naming (so let's stick the executable nitropy first), especially relevant for the articles linking into software/nitropy 2) like the sub-articles shown in software, but here we need consistency, too either have this like that everywhere or nowhere

In order to merge: 1) can be easily done by grepping for pynitrokey I guess and 2) is just adding max-depth: 2 everywhere then we just merge, wait for some feedback for 2) and keep or remove it afterwards...

jans23 commented 2 years ago

IMO consistent naming would be pynitrokey because that's used in other places of the documentation already and it' the name of the software.

szszszsz commented 2 years ago

Agreed. We had that decision back then and have to stick now. pynitrokey is the name, and nitropy is the tool's call. This should be documented too to clear the doubts. Briefly looking, these pages look good enough. Let's merge it!

robin-nitrokey commented 2 years ago

@jans23

IMO consistent naming would be pynitrokey because that's used in other places of the documentation already and it' the name of the software.

@szszszsz

Agreed. We had that decision back then and have to stick now. pynitrokey is the name, and nitropy is the tool's call. This should be documented too to clear the doubts. Briefly looking, these pages look good enough. Let's merge it!

I discussed the naming topic with @daringer last week and we had a different understanding: pynitrokey is only the name for the package and not relevant for the user, nitropy (or: nitrokey-tool in the future) is the actual application. We even discussed whether we should go forward with the renaming before publishing this. (Also, the NetHSM and Nitrokey 3 documentation already uses the name nitropy.) Should I rename nitropy to pynitrokey in the docs anyway?

robin-nitrokey commented 2 years ago

like the sub-articles shown in software, but here we need consistency, too either have this like that everywhere or nowhere

@daringer Can you please elaborate on that? Is this about the navigation bar or the list in the page body? And what is the expected output?

jans23 commented 2 years ago

Should I rename nitropy to pynitrokey in the docs anyway?

No opinion. Renaming would be most appreciated.

daringer commented 2 years ago

@daringer Can you please elaborate on that? Is this about the navigation bar or the list in the page body? And what is the expected output?

If I navigate into "Software" -> "nitropy" I can see a toc with the depth 2, instead of depth 1 (as it is everywhere else, e.g. nextbox). So "software" -> "nitropy" looks like this:

and e.g. NextBox looks like this (even though there are depth 2 items):

actually I like the max-depth: 2 approach a little more - whichever we choose it should be consistent.

szszszsz commented 2 years ago

Bumping

jans23 commented 2 years ago

I agree to the above reasoning and think "nitropy" is the most appropriate name as of now (which will be renamed in the future).

Can this be merged?

jans23 commented 2 years ago

Title words should start with capital letters.

szszszsz commented 2 years ago

Let's merge it and clean up later (by adding another ticket / PR). It's better to have an imperfect description, than having none.