search

Nitrokey / nitrokey-hotp-verification

A command line C app to validate HOTP codes on Heads
GNU General Public License v3.0
11 stars 10 forks source link

Making patch in Heads unnecessary by adapting changes #15

Closed alex-nitrokey closed 4 years ago

alex-nitrokey commented 4 years ago

This PR shall make this patchfile in Heads unnecessary. The changes can be included in nitrokey-hotp-verification right away.

The patch in Heads still has a bigger part for the ToolchainMakefile, but the patch is currently not applied, because the patch wasn't renamed during this commit. We might include the Makefile stuff here as well, to get rid of the patchfile and the need to adapt it every time we need to update nitrokey-hotp-verification.

@szszszsz please have a look if this can be included in your heads specific makefile (if not done already anyways).

szszszsz commented 4 years ago

The CMake part of the patch could be added as well. I will merge this in the meantime.

Edit: how come we do not have CI here yet?

szszszsz commented 4 years ago

Mentioned patch: https://github.com/osresearch/heads/blob/master/patches/libremkey-hotp-verification-e5fa36a7a1950226d0ef94e2eeed0ffb510eba89.patch

CI has passed on Gitlab: https://gitlab.com/szszszsz/nitrokey-hotp-verification-github/-/jobs/587498581

alex-nitrokey commented 4 years ago

The CMake part of the patch could be added as well. I will merge this in the meantime.

Not necessary as the cmake is not used in heads anymore. Therefore, I can delete the patch safely in heads.