Nitrokey / nitrokey-pro-firmware

Firmware for the Nitrokey Pro device
GNU General Public License v3.0
119 stars 22 forks source link

HSM: Remove HID interface from device descriptor and change Name #15

Closed FlorianUekermann closed 8 years ago

FlorianUekermann commented 8 years ago

Can we make this a new branch instead of applying to master? That would make life a bit easier when working on the Pro stuff.

szszszsz commented 8 years ago

Hi @MaVo159, Sure! I have created hsm branch in repo (where I have already included your commit). Please make future PRs against it.

FlorianUekermann commented 8 years ago

Ok. I see you also fixed the interface number (on my side the OS didn't seem to care about it). Could you also change the device Id to whatever the HSM uses?, Then I don't have to send another pull request.

szszszsz commented 8 years ago

Do you mean default PID? Indeed this might be helpful. In the meantime you can use: make PID=0x4230

FlorianUekermann commented 8 years ago

Yes that is what I meant. Thanks.