Nitrokey / nitrokey-pro-firmware

Firmware for the Nitrokey Pro device
GNU General Public License v3.0
118 stars 21 forks source link

Can't add AWS MFA secret #22

Closed jans23 closed 7 years ago

jans23 commented 7 years ago

The original ticket is here: https://github.com/Nitrokey/nitrokey-app/issues/26

szszszsz commented 7 years ago

To sum up: issue is caused by storage limitations and needs it's structure redesign.

tripleclones commented 7 years ago

Can you give any time frames on this please?

Just to clarify I have experienced more services using longer secret keys which are incompatible other then AWS

jans23 commented 7 years ago

No time frame yet. Which are these other services you are mentioning?

szszszsz commented 7 years ago

Current TOTP secret given by AWS is 64 base32 characters which is 40 bytes (320 bits).

tripleclones commented 7 years ago

VPS provider Bitfolk is the one that springs to mind but I'm sure there was another as well, I will check some other providers I use

jans23 commented 7 years ago

We are going to tailor our devices to AWS's secret length. It would be important, how long the secrets of those other providers is and if such exceed the secret's length AWS is using.

tripleclones commented 7 years ago

When I set up AWS I was given a 64 Byte key. Bitfolk provided a 80 Byte key. As I understand it the Nitrokey is current limited to 32 Bytes?

szszszsz commented 7 years ago

Hi! @tripleclones Could you tell, are these bytes encoded base32, base64 or hex? Are there any information of their type? I guess the first, but wanted to confirm.
Edit: as for the question, currently Nitrokey can store 160 bits long keys (which is 32 bytes while encoded in base32).

tripleclones commented 7 years ago

I appears to be base32 yes, 50 Bytes decoded.

Although I have asked the question of Bitfolk to be sure.

tripleclones commented 7 years ago

Confirmed 50 bytes base32 encoded

tripleclones commented 7 years ago

OK so Bitfolk have drop the requirements of their key to fit in with the current 32 base32 - so its just AWS now :)

szszszsz commented 7 years ago

The AWS OTP keys will be supported from now on Nitrokey Pro v0.8 and hopefully on Nitrokey Storage next versions (v0.44+).