Nitrokey / nitrokey-websmartcard

Nitrokey WebSmartCard Specification and Documentation
29 stars 3 forks source link

Add diagrams, and extend summaries #28

Closed szszszsz closed 1 year ago

szszszsz commented 1 year ago

Make sure to view the diff in the richtext mode:

szszszsz commented 1 year ago

In the diagrams the "Nitrokey WebSmartCard API" would be loaded as a Javascript library correct?

That's correct. It will be then injected as a plugin object into OpenPGP.js through its plugin mechanism.

I think it might be worth nesting it inside of the OpenPGP.js client application somehow to make it clearer what happens in the website, the browser, and the NK3

I think this is a task for the communication channel diagram, and its description. I will see if I can improve it. One thing is to name Nitrokey WebSmartCard API as a Javascript library. In general, while I agree adding server/service as another participant here is technically more precise, I am worried it will make the chart obscure.

szszszsz commented 1 year ago

@daringer Let's discuss later if, and what are you missing from the Seed and Key Generation chapter regarding initialization. @sosthene-nitrokey I've boxed the Javascript app into a "Web Browser" group, and introduced an optional Web Service communication. Hopefully this clears the general image a bit.