search

Nitrokey / opcard-rs

OpenPGP card implementation
49 stars 1 forks source link

Add support for large certificates #140

Closed sosthene-nitrokey closed 1 year ago

sosthene-nitrokey commented 1 year ago

For some reason I don't understand the tests fail with a panic in openpgp-card

sosthene-nitrokey commented 1 year ago

Do we want to merge this now (after commenting the failing test commenting from openpgp-card)?

robin-nitrokey commented 1 year ago

Which test case is failing? Are the arbitrary DOs still covered by the test suite even if that test case is skipped?

sosthene-nitrokey commented 1 year ago

The test case that is failing is the one with the large certificate in tests/dos.rs. To still test the functionality I added a test for the same thing in command_response, so large certificates are tested and appear to work.

We can make the failing test work again by restoring it to its previous state (with a small certificate). The test fails not because of the card panicking, but because opengpg-card fails to construct a large APDU, because of some apparent error in the card_caps implementation.

Relevant upstream bug report: https://gitlab.com/openpgp-card/openpgp-card/-/issues/69

robin-nitrokey commented 1 year ago

Okay, then let’s merge the change with a skipped or modified test case.

sosthene-nitrokey commented 1 year ago

Huh, there's more conflict with data-encryption than I anticipated

sosthene-nitrokey commented 1 year ago

Replaced by #150