search

Nitrokey / opcard-rs

OpenPGP card implementation
49 stars 1 forks source link

Add dangerous-test-real-card feature to run the tests on a real card. #97

Closed sosthene-nitrokey closed 1 year ago

sosthene-nitrokey commented 1 year ago

This is labeled as dangerous as it will wipe the pgp smartcard plugged in. This feature only affects tests and is incompatible with --virtual

robin-nitrokey commented 1 year ago

What do you think about adding an environment valuable that is used to store the serial number of the smartcard to test? If it does not match the connected card, the tests are aborted. This would ensure that they are not accidentally executed with a production smartcard.

sosthene-nitrokey commented 1 year ago

Good idea! We still need the feature flag to remove the with_vsc in testing though