Nitrokey / pynitrokey

Python client for Nitrokey devices
Apache License 2.0
93 stars 28 forks source link

fido2.client: Raise unhandled error in cred_mgmt #358

Closed robin-nitrokey closed 1 year ago

robin-nitrokey commented 1 year ago

An error with an unexpected error code was previously ignored in NKFido2Client.cred_mgmt, leading to an uninitialized variable being used in the following code. This patch fixes the issue by raising all unhandled errors.

Fixes: https://github.com/Nitrokey/pynitrokey/issues/355

Checklist

szszszsz commented 1 year ago

The source error does not have any local_prints though

szszszsz commented 1 year ago

Must have been something else than CtapError.ERR.*, but raise should now make it a friendly user message, should it not?

Edit: it does look so - it has _str_ method