Nitrokey / pynitrokey

Python client for Nitrokey devices
Apache License 2.0
93 stars 28 forks source link

CD pipeline to publish on Pypi #372

Closed mmerklinger closed 1 year ago

mmerklinger commented 1 year ago

This PR adds a CD pipeline to publish on Pypi.

Changes

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

Test Environment and Execution

Relevant Output Example

Fixes #

mmerklinger commented 1 year ago

I left in the jobs for the Gitlab CI. Should I remove them?

robin-nitrokey commented 1 year ago

I’m in favor of removing the unused Gitlab CI scripts. If we migrate back to Gitlab, we can still find them in the Git history.

daringer commented 1 year ago

yip please remove the gitlab toolchain

mmerklinger commented 1 year ago

Build and publish jobs from .gitlab-ci.yml file removed.

daringer commented 1 year ago

lgtm merge?

mmerklinger commented 1 year ago

From my side the issue is finished. You need to merge though.