nk3 update: Handle NK3CN bootloader issues - Githubissues

Nitrokey / pynitrokey

Python client for Nitrokey devices

Apache License 2.0

98 stars 27 forks source link

nk3 update: Handle NK3CN bootloader issues #378

Closed robin-nitrokey closed 1 year ago

robin-nitrokey commented 1 year ago

This PR tries to fix some issues with the NK3CN bootloader, e. g. https://github.com/Nitrokey/nitrokey-3-firmware/issues/250.

Changes

Ensure that the _get_bootloader context manager only yields once.
Ensure that the bootloader is opened before accessing it.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

[x] tested with Python3.9
[x] signed commits
[ ] updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
[x] added labels

Test Environment and Execution

OS: Debian 11
device's model:
device's firmware version:

robin-nitrokey commented 1 year ago

Replaced by: https://github.com/Nitrokey/pynitrokey/pull/446