Nitrokey / pynitrokey

Python client for Nitrokey devices
Apache License 2.0
93 stars 28 forks source link

Remove command-line arguments for PINs and passwords #401

Open robin-nitrokey opened 1 year ago

robin-nitrokey commented 1 year ago

As discussed earlier, the default input method for PINs, passwords and other secrets should be interactive prompts. To allow scripting, environment variables should be supported too. Command-line arguments should be removed as they are at a higher risk to end up in process lists, shell histories, logs, etc.

See also:

daringer commented 6 months ago

to bring this forward the next step here is to come up with a complete list of pins/passwords used in pynitrokey and have a proper suggestion how these can be provided alternatively.

Laborratte5 commented 6 months ago

As a start the CLI_LOG_BLACKLIST in confconst.py could be used, containing:

However digging around the related issues this list is not complete as it at least misses secrets add-password --password TEXT and maybe some others too.